Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛: elbv2: skip adding security groups to NLB in secret regions #5030

Merged
merged 2 commits into from
Sep 5, 2024
Merged

🐛: elbv2: skip adding security groups to NLB in secret regions #5030

merged 2 commits into from
Sep 5, 2024

Conversation

r4f4
Copy link
Contributor

@r4f4 r4f4 commented Jun 20, 2024

Secret regions don't yet support security groups for NLBs.

What type of PR is this?

/kind bug

What this PR does / why we need it:

C2S/SC2S regions do not support security groups on Network load balancers.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5029

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Fix: do not attach security groups for Network Load Balancers in secret regions.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Jun 20, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @r4f4. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 20, 2024
@r4f4 r4f4 mentioned this pull request Jun 20, 2024
Merged
@r4f4
Copy link
Contributor Author

r4f4 commented Jun 20, 2024

Openshift e2e results for the public cloud are good (no breakage): openshift/installer#8636

I'm trying to get this changed tested on a secret region.

@richardcase
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 1, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Jul 1, 2024

/test ?

@k8s-ci-robot
Copy link
Contributor

@r4f4: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-build-docker
  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-main
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e-clusterclass
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-eks
  • /test pull-cluster-api-provider-aws-e2e-eks-gc
  • /test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-main
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-build-docker
  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

r4f4 added 2 commits July 1, 2024 22:37
@r4f4
🐛elb: fix printing info message with ELB name
1504d25 
Fixes the following message being printed:
```
loadbalancer.go:1799: Pre-existing NLB %s without security groups, cannot reconcile security groups
```
to actually include the load balancer's name.
@r4f4
🐛: elbv2: skip adding security groups to NLB in secret regions
dc6ee06 
Secret regions don't yet support security groups for NLBs.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Jul 1, 2024

Update:

  • add a fix for info message with a spurious "%s"
  • print a different message for regions that do not support NLB security groups. loadbalancer.go:1799: Pre-existing NLB %s without security groups, cannot reconcile security groups might be confusing on those cases.

@r4f4
Copy link
Contributor Author

r4f4 commented Jul 1, 2024

/test pull-cluster-api-provider-aws-e2e-blocking

@dmc5179
Copy link

dmc5179 commented Jul 31, 2024

I'm an OCP SSA supporting the customers who use the us-iso and us-isob regions. In earlier testing of the new CAPA changes I discovered that, while AWS commercial supports NLBs with security groups, the us-iso and us-isob regions do not. If the openshift-installer attempts to add security groups to an NLB in the iso regions it will fail and error out. I tested this proposed code change in the us-iso regions and found that the openshift-installer successfully provisions the NLBs without security groups.

@r4f4
Copy link
Contributor Author

r4f4 commented Jul 31, 2024

Now that we've tested it in a secret cloud:
/assign @richardcase

damdo
damdo reviewed Aug 2, 2024
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2024
@damdo
Copy link
Member

damdo commented Sep 5, 2024

/assign @richardcase @nrb
Would you mind stamping you approval here? TY

@nrb
Copy link
Contributor

nrb commented Sep 5, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2cbd9ad into kubernetes-sigs:main Sep 5, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo damdo left review comments

@AndiDog AndiDog Awaiting requested review from AndiDog

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@richardcase richardcase

@nrb nrb

@damdo damdo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Secret clouds don't support Security Groups on NLBs
6 participants
@r4f4 @k8s-ci-robot @richardcase @dmc5179 @damdo @nrb