🐛 Mark S3BucketCreated condition ready after successful reconciliation

[AndiDog]

What type of PR is this?

/kind bug

What this PR does / why we need it:

The ready condition never gets set. This was likely just a minor oversight in the initial implementation. I noticed because we had a temporary failure where CAPA didn't remove the non-ready mark for the condition after having successfully reconciled the bucket later.

I left out amending any test since there seems to be no full reconciliation test for bucket-backed cluster creation.

Checklist:

• squashed commits
• includes documentation
• includes emojis
• adds unit tests
• adds or updates e2e tests

Release note:

Mark `S3BucketCreated` condition ready after successful reconciliation

[AndiDog]

/test pull-cluster-api-provider-aws-e2e

[damdo]

/lgtm

[AndiDog]

/assign @kubernetes-sigs/cluster-api-provider-aws-maintainers

for approval

[damdo]

/assign @nrb

[nrb]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nrb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment