Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private clusters #486

Closed
CecileRobertMichon opened this issue Apr 3, 2020 · 8 comments · Fixed by #974
Closed

Private clusters #486

CecileRobertMichon opened this issue Apr 3, 2020 · 8 comments · Fixed by #974
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. parity Used to track feature parity with other Azure provisioning tools (AKS, AKS Engine, etc)
Milestone

Comments

@CecileRobertMichon
Copy link
Contributor

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

Support deploying clusters with no public IP or external load balancer. For reference: https://github.com/Azure/aks-engine/blob/master/docs/topics/features.md#feat-private-cluster.

Once Azure Bastion is implemented, we should document using Azure Bastion + Private clusters. related to #165

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • cluster-api-provider-azure version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 3, 2020
@CecileRobertMichon
Copy link
Contributor Author

/help

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Apr 3, 2020
@CecileRobertMichon
Copy link
Contributor Author

note: we may need to change https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/master/controllers/azurecluster_controller.go#L128 to wait for the private IP instead of the DNS name:

	// TODO: We may need to use azureCluster.Status.Network.APIServerIP.IPAddress
	//       instead when we look at configuring private clusters.

@rbitia
Copy link
Contributor

rbitia commented Jun 4, 2020

parity

@k8s-ci-robot
Copy link
Contributor

@rbitia: The label(s) /label parity cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash

In response to this:

/label parity

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CecileRobertMichon CecileRobertMichon added the parity Used to track feature parity with other Azure provisioning tools (AKS, AKS Engine, etc) label Jun 4, 2020
@CecileRobertMichon CecileRobertMichon added this to the next milestone Jun 4, 2020
@CecileRobertMichon
Copy link
Contributor Author

1st step is to define what the implementation would look like

/cc @jseely

@CecileRobertMichon
Copy link
Contributor Author

/assign

@CecileRobertMichon
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. parity Used to track feature parity with other Azure provisioning tools (AKS, AKS Engine, etc)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants