enable metrics scraping via prometheus

[bavarianbidi]

prometheus as the defacto standard for monitoring in a kubernetes
environment is generally configured to scrape metrics only if the
observed targets (pods, service, endpoints) has set proper annotations.

What type of PR is this?

/kind other

What this PR does / why we need it:
with PR #4247 in capi we introduced some notes about monitoring/scraping metrics via prometheus. This PR will add the relevant annotations to make it work in a defacto default prometheus setup.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1222

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

metrics service got some additional annotations which can be used by prometheus for a more fine-grained scrape configuration

Signed-off-by: Constanti, Mario mario.constanti@daimler.com

Mario Constanti mario.constanti@daimler.com, Daimler TSS GmbH, legal info/Impressum

[k8s-ci-robot]

@bavarianbidi: The label(s) kind/other cannot be applied, because the repository doesn't have them.

In response to this:

prometheus as the defacto standard for monitoring in a kubernetes
environment is generally configured to scrape metrics only if the
observed targets (pods, service, endpoints) has set proper annotations.

What type of PR is this?

/kind other

What this PR does / why we need it:
with PR #4247 in capi we introduced some notes about monitoring/scraping metrics via prometheus. This PR will add the relevant annotations to make it work in a defacto default prometheus setup.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1222

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Signed-off-by: Constanti, Mario mario.constanti@daimler.com

Mario Constanti mario.constanti@daimler.com, Daimler TSS GmbH, legal info/Impressum

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @bavarianbidi!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @bavarianbidi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

/ok-to-test

[sbueringer]

/lgtm

[CecileRobertMichon]

@bavarianbidi thanks for the PR, can you please add a release note in the PR description?

[bavarianbidi]

@bavarianbidi thanks for the PR, can you please add a release note in the PR description?

done

[devigned]

/lgtm
/approve

Thank you for the PR!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devigned

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [devigned]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[devigned]

/retest