-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make azure credentials optional in manager deployment #1445
Make azure credentials optional in manager deployment #1445
Conversation
/assign @nader-ziada @devigned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Yay! One step closer to no creds in the controller.
should we wait until the issues with private cluster/dns thing is resolved? |
I don't think that's necessarily a blocker since it can still be used with creds, although it would be nice to figure out that one before the release. Is there a tracking issue for the dns issue? |
/hold cancel |
I was hoping for #1360 to get merged in first, but I guess the order doesn't really matter /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nader-ziada The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-cluster-api-provider-azure-e2e |
What type of PR is this?
What this PR does / why we need it: Following up on #1386 and #977, this makes the Azure credentials environment variables optional in the infrastructure components yaml spec by defaulting the values to "". When not setting the environment variables in the manager, the user will need to specify an AzureClusterIdentity for each workload cluster.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/hold
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: