-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests/Account & Domain Isolation and More Doman/Account Tests #101
Tests/Account & Domain Isolation and More Doman/Account Tests #101
Conversation
I think your PR's base is wrong - we want to merge into the fork, not kubernetes-purgatory, right? |
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
/test-cla |
/check-cla |
/easycla |
@rejoshed: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rejoshed The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closing to reopen from my own fork. |
1 similar comment
Closing to reopen from my own fork. |
Issue #, if available:
N/A
Description of changes:
Adds Domain/Account/User creation and cleanup on unit test runs.
The unit tests now still only take about 15 seconds, but now they run in a domain with UUID that is cleaned up afterwards. This allows test isolation and helps to guarantee failed test cleanup.
In doing so I've also managed to turn enable about 40+ unit tests that were skipped in the pipeline previously.
This PR also moves unit tests to their own module/folder. This allows tools like dep check to consider our go.mod and go.sum without additional back bending to remove test only requirements.
Testing performed:
More than before!
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.