Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/Account & Domain Isolation and More Doman/Account Tests #101

Conversation

rejoshed
Copy link
Contributor

@rejoshed rejoshed commented May 26, 2022

Issue #, if available:
N/A

Description of changes:
Adds Domain/Account/User creation and cleanup on unit test runs.

The unit tests now still only take about 15 seconds, but now they run in a domain with UUID that is cleaned up afterwards. This allows test isolation and helps to guarantee failed test cleanup.

In doing so I've also managed to turn enable about 40+ unit tests that were skipped in the pipeline previously.

This PR also moves unit tests to their own module/folder. This allows tools like dep check to consider our go.mod and go.sum without additional back bending to remove test only requirements.

Testing performed:
More than before!

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@maxdrib
Copy link
Contributor

maxdrib commented May 27, 2022

I think your PR's base is wrong - we want to merge into the fork, not kubernetes-purgatory, right?

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 30, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 30, 2022
@rejoshed
Copy link
Contributor Author

/test-cla

@pmotyka
Copy link
Contributor

pmotyka commented May 31, 2022

/check-cla

@pmotyka
Copy link
Contributor

pmotyka commented May 31, 2022

/easycla

@k8s-ci-robot k8s-ci-robot removed the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 31, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2022
@k8s-ci-robot
Copy link
Contributor

@rejoshed: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 10, 2022
@rejoshed rejoshed changed the title Tests/add more domain account tests Tests/Account & Domain Isolation and More Doman/Account Tests Jun 10, 2022
@netlify
Copy link

netlify bot commented Jun 10, 2022

Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

Name Link
🔨 Latest commit de6f708
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-cloudstack/deploys/62a3c2c5a1580d0009a4ee46
😎 Deploy Preview https://deploy-preview-101--kubernetes-sigs-cluster-api-cloudstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rejoshed
To complete the pull request process, please assign maxdrib after the PR has been reviewed.
You can assign the PR to them by writing /assign @maxdrib in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rejoshed
Copy link
Contributor Author

Closing to reopen from my own fork.

1 similar comment
@rejoshed
Copy link
Contributor Author

Closing to reopen from my own fork.

@rejoshed rejoshed closed this Jun 16, 2022
@rejoshed rejoshed closed this Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants