-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Conditions #570
Comments
Hi, @pydctw I would like to work on this. I did some research using some of the links you provided and looking at CAPZ and here is what I understand so far: A few new types would need to be introduced like CAPZ does over here: The current GCPmachine status spec would need to be updated to include Here's what I currently don't understand
I'm probably missing a lot more but I hope this is sufficient information to get started |
Hi @s1ntaxe770r, thanks for your interest in the issue. Very happy to hear that. You are on the correct path - providers usually create a file called conditions_consts.go to define the condition types and clusterv1.Conditions field needs to be added to GCPmachine status.
Each providers have slightly different conditions. For GCP, take a look at what's returned from GCP instance get call
Yes, reading other providers code will definitely give you a good idea as infraMachine controllers have similar structure. I would suggest reading awsmachine_controller and investigate conditions. |
Hey, @pydctw thanks for pointing me in the right direction. I've looked through the links and have a few more questions
|
Created two sub-issues. Let's continue the discussion for GCPMachine conditions in #576 |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/remove-lifecycle rotten |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind feature
Describe the solution you'd like
Add Conditions to
GCPCluster.Status
andGCPMachine.Status
CAPI ecosystem implemented Conditions to show the Cluster status at glance. It will be great to add conditions to GCPCluster and GCPMachine to help users to understand the status of each object better.
Tasks
These tasks can be done in parallel. Feel free to pick one or the other.
Related docs
Anything else you would like to add:
Other providers have implemented conditions so take a look at CAPA or CAPZ for reference.
The text was updated successfully, but these errors were encountered: