Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for feature gates #644

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

evanfreed
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:
Adds the ability to use feature gates.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #643

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Adding features via feature gate

/feature

Signed-off-by: Evan Freed evan.freed@protonmail.ch

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 30, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @evanfreed. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 30, 2022
@sayantani11
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 1, 2022
@sayantani11
Copy link
Contributor

@evanfreed Please run make modules and make verify-modules and try pushing the PR again.

@evanfreed evanfreed force-pushed the feat_feature_gate branch from 3e87014 to b6c8a6b Compare July 15, 2022 16:12
@evanfreed
Copy link
Contributor Author

evanfreed commented Jul 15, 2022

Sorry for the delay, I had some time off so I didn't look at this. I repushed after running make modulesand make verify-modules. Looks like there was an update to the go mod file, must have snuck in with a different commit but should be fixed up 🤞

@eaceaser
Copy link
Contributor

eaceaser commented Aug 5, 2022

Hi! I'm working on a PR where I would love to feature gate support -- is there anything I can do to help this PR get merged?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2022
@evanfreed
Copy link
Contributor Author

@eaceaser sorry for the delay in response, I was on vacation for a bit. I think we're good here now that I rebased, I'm just waiting for a review.

@evanfreed
Copy link
Contributor Author

@sayantani11 @fabriziopandini or @sbueringer would you be willing to take a look? 🙏 thanks in advanced

@sbueringer
Copy link
Member

sbueringer commented Aug 15, 2022

/cc @cpanato

@evanfreed Fabrizio and I are mostly in the reviewer list because maintainers of core CAPI were synced into the OWNERS file of CAPG.

@k8s-ci-robot k8s-ci-robot requested a review from cpanato August 15, 2022 16:14
@evanfreed
Copy link
Contributor Author

No worries! Thanks @sbueringer

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 23, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2022
@evanfreed
Copy link
Contributor Author

@cpanato when you get a chance could you look this over? I've been trying to get this one finished up for a while.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2022
Signed-off-by: Evan Freed <evan.freed@protonmail.ch>
@evanfreed
Copy link
Contributor Author

@pydctw is there a chance you'd be able to look at this? I'm struggling to find a reviewer.

@pydctw
Copy link

pydctw commented Nov 2, 2022

sure. thanks for adding the feature gate support, @evanfreed
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2022
@pydctw
Copy link

pydctw commented Nov 2, 2022

/assign @cpanato for approval

@k8s-ci-robot
Copy link
Contributor

@pydctw: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @cpanato for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks cool
thanks
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, evanfreed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2b98452 into kubernetes-sigs:main Nov 3, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Feature Gates
7 participants