-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for feature gates #644
Conversation
Hi @evanfreed. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@evanfreed Please run |
3e87014
to
b6c8a6b
Compare
Sorry for the delay, I had some time off so I didn't look at this. I repushed after running |
Hi! I'm working on a PR where I would love to feature gate support -- is there anything I can do to help this PR get merged? |
b6c8a6b
to
54d4499
Compare
@eaceaser sorry for the delay in response, I was on vacation for a bit. I think we're good here now that I rebased, I'm just waiting for a review. |
@sayantani11 @fabriziopandini or @sbueringer would you be willing to take a look? 🙏 thanks in advanced |
6fd2170
to
e8ecd90
Compare
/cc @cpanato @evanfreed Fabrizio and I are mostly in the reviewer list because maintainers of core CAPI were synced into the OWNERS file of CAPG. |
No worries! Thanks @sbueringer |
e8ecd90
to
5b6e359
Compare
@cpanato when you get a chance could you look this over? I've been trying to get this one finished up for a while. |
5b6e359
to
85909ec
Compare
Signed-off-by: Evan Freed <evan.freed@protonmail.ch>
85909ec
to
307d99c
Compare
@pydctw is there a chance you'd be able to look at this? I'm struggling to find a reviewer. |
sure. thanks for adding the feature gate support, @evanfreed |
/assign @cpanato for approval |
@pydctw: GitHub didn't allow me to assign the following users: for, approval. Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks cool
thanks
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, evanfreed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Adds the ability to use feature gates.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #643
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note:
/feature
Signed-off-by: Evan Freed evan.freed@protonmail.ch