Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: per cluster credentials #775

Merged
merged 1 commit into from
Dec 7, 2022
Merged

feat: per cluster credentials #775

merged 1 commit into from
Dec 7, 2022

Conversation

richardcase
Copy link
Member

@richardcase richardcase commented Dec 6, 2022 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This change allows you to optionally specify credentials to use for the cluster provisioning instead of using the controller's credentials.

You specify a reference to a Secret via the credentialsRef. The secret must have the service account json added with a key called credentials.

Signed-off-by: Richard Case richard.case@outlook.com

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #575

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Allow specifying the credentials to use on a per cluster basis

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 6, 2022
@k8s-ci-robot k8s-ci-robot requested review from cpanato and dims December 6, 2022 12:06
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 6, 2022
@richardcase
feat: per cluster credentials
e184260 
This change allows you to optionally specify credentials to use for the
cluster provisioning instead of using the controllers credentials.

You specify a reference to a Secret via the `credentialsRef`. The secret
must have the service account json added with a key called
**credentials**.

The e2e tests have been extended to include a test that uses the
credentials.

Signed-off-by: Richard Case <richard.case@outlook.com>
@richardcase
Copy link
Member Author

/override pull-cluster-api-provider-gcp-apidiff

@k8s-ci-robot
Copy link
Contributor

@richardcase: richardcase unauthorized: /override is restricted to Repo administrators.

In response to this:

/override pull-cluster-api-provider-gcp-apidiff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 6, 2022
@richardcase richardcase changed the title [WIP] feat: per cluster credentials feat: per cluster credentials Dec 6, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2022
@cpanato
Copy link
Member

cpanato commented Dec 7, 2022

/override pull-cluster-api-provider-gcp-apidiff

@k8s-ci-robot
Copy link
Contributor

@cpanato: Overrode contexts on behalf of cpanato: pull-cluster-api-provider-gcp-apidiff

In response to this:

/override pull-cluster-api-provider-gcp-apidiff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cpanato
cpanato approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks!
/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 10b1beb into kubernetes-sigs:main Dec 7, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@dims dims Awaiting requested review from dims

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Support single Controller Multitenancy
3 participants
@richardcase @k8s-ci-robot @cpanato