Skip to content

Commit

Permalink
Remove the setup counter from the KVMachine ready status
Browse files Browse the repository at this point in the history
Cluster-API takes the reason and the message from the infra-machine (in
our case, the KubeVirtMachine) `Ready` condition, into `Machine`
`InfrastructureReady` condition. Currently the text is something like
`"0 of 2 completed"`. This is not very informative.

This PR changes the behavior so now the KV Machine Ready condition will
include both the reason and the message from the failed condition.

That way, the cluster-api `InfrastructureReady` condition, will also
contain the same reason and message. This will make the actual issue, if
exists, to more accessible to the user.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
  • Loading branch information
nunnatsa committed Dec 25, 2023
1 parent 1ab9fc5 commit 94a369b
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion pkg/context/machine_context.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ func (c *MachineContext) PatchKubevirtMachine(patchHelper *patch.Helper) error {
infrav1.VMProvisionedCondition,
infrav1.BootstrapExecSucceededCondition,
),
conditions.WithStepCounterIf(c.KubevirtMachine.ObjectMeta.DeletionTimestamp.IsZero()),
)

// Patch the object, ignoring conflicts on the conditions owned by this controller.
Expand Down

0 comments on commit 94a369b

Please sign in to comment.