Introduce cluster template with Passt binding #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
Pull Request Test Coverage Report for Build 3581237415
💛 - Coveralls |
added 5 commits
November 29, 2022 12:34
Signed-off-by: Radim Hrazdil <rhrazdil@redhat.com>
Signed-off-by: Radim Hrazdil <rhrazdil@redhat.com>
So the template can be easily chosen by setting an env variable Signed-off-by: Radim Hrazdil <rhrazdil@redhat.com>
Signed-off-by: Radim Hrazdil <rhrazdil@redhat.com>
Because v0.58.0 doesn't contain the fix (kubevirt/kubevirt#8578) for passt as it advertises. Signed-off-by: Radim Hrazdil <rhrazdil@redhat.com>
rhrazdil
force-pushed
the
passt_binding_2
branch
from
16279e4
to
648db22
Compare
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
Signed-off-by: Radim Hrazdil <rhrazdil@redhat.com>
rhrazdil
force-pushed
the
passt_binding_2
branch
from
648db22
to
cf2dd64
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidvossel, rhrazdil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds template with VMs using Passt binding to pod network.
Passt featureGate is enabled in kubevirtci script and Passt recommended node configuration is performed on cluster-up.
NOTE: There is a commit bumping kubevirt to 0.59.0-alpha, because while kubevirt/kubevirt#8578 is merged in kubevirt release-0.58 branch, the change hasn't made it to v0.58.0 tag.
Lastly, an e2e test is added to exercise cluster creation with Passt binding.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release notes: