Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the release automation #215

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Fix the release automation #215

merged 1 commit into from
Dec 2, 2022

Conversation

nunnatsa
Copy link
Contributor

@nunnatsa nunnatsa commented Dec 2, 2022 •
edited
Loading

Remove non-exist file from the release asset list.

Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release notes:

None

@nunnatsa
Fix the release automation
d1aee70 
Remove non-exist file from the release asset list.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 2, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 2, 2022
@nunnatsa
Copy link
Contributor Author

nunnatsa commented Dec 2, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 2, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3599310348

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.459%
Totals Coverage Status
Change from base Build 3596866967: 0.0%
Covered Lines: 952
Relevant Lines: 1850
💛 - Coveralls

qinqon
qinqon approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@qinqon qinqon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa, qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e4372d3 into kubernetes-sigs:main Dec 2, 2022
@nunnatsa nunnatsa deleted the fix-release branch December 2, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinqon qinqon qinqon approved these changes

@agradouski agradouski Awaiting requested review from agradouski

Assignees

@qinqon qinqon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nunnatsa @coveralls @k8s-ci-robot @qinqon