Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kube-rbac-proxy #222

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Conversation

yuanchen8911
Copy link
Member

@yuanchen8911 yuanchen8911 commented Jan 31, 2023

What this PR does / why we need it:

Following the upstream cluster-api instruction, remove unneeded component kube-rbac-proxy.

Which issue this PR fixes

Remove uneeded kube-rbac-proxy.

Special notes for your reviewer:

Tested the changes locally to bring up capi controller managers and capk controller managers.

[yuanchen:~/projects/aci/go/cluster-api-provider-kubevirt/e2e]$ kubectl get pods -A
NAMESPACE                           NAME                                                            READY   STATUS    RESTARTS      AGE
capi-kubeadm-bootstrap-system       capi-kubeadm-bootstrap-controller-manager-64fcd4ff4d-p6jgh      1/1     Running   0             6m41s
capi-kubeadm-control-plane-system   capi-kubeadm-control-plane-controller-manager-6f86697dc-jmn8f   1/1     Running   0             6m40s
capi-system                         capi-controller-manager-7847d5c678-8gqbh                        1/1     Running   0             6m41s
capk-system                         capk-controller-manager-67c486ffd6-wm4h4                        2/2     Running   2 (72s ago)   5m37s
cert-manager                        cert-manager-6dc4964c9-gp2kg                                    1/1     Running   0             7m3s
cert-manager                        cert-manager-cainjector-69d4647c6-fdzmx                         1/1     Running   0             7m3s
cert-manager                        cert-manager-webhook-75f77865c8-4b7dq                           1/1     Running   0             7m3s
kube-system                         coredns-565d847f94-kvbc6                                        1/1     Running   0             28m
kube-system                         coredns-565d847f94-zghlh                                        1/1     Running   0             28m
kube-system                         etcd-kubevirt-control-plane                                     1/1     Running   0             29m
kube-system                         kindnet-vjtk5                                                   1/1     Running   0             29m
kube-system                         kube-apiserver-kubevirt-control-plane                           1/1     Running   0             29m
kube-system                         kube-controller-manager-kubevirt-control-plane                  1/1     Running   0             29m
kube-system                         kube-proxy-vxtxb                                                1/1     Running   0             29m
kube-system                         kube-scheduler-kubevirt-control-plane                           1/1     Running   0             29m
local-path-storage                  local-path-provisioner-684f458cdd-sgrm6                         1/1     Running   0             2

Release notes:

Remove kube-rbac-proxy 

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 31, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 31, 2023
@yuanchen8911
Copy link
Member Author

/cc @cchengleo

@coveralls
Copy link

coveralls commented Jan 31, 2023

Pull Request Test Coverage Report for Build 4057721529

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.655%

Totals Coverage Status
Change from base Build 3882884209: 0.0%
Covered Lines: 952
Relevant Lines: 1808

💛 - Coveralls

Remove kube-rbac-proxy from kubevirtci
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 31, 2023
@yuanchen8911 yuanchen8911 reopened this Jan 31, 2023
@yuanchen8911
Copy link
Member Author

/cc @agradouski

@cchengleo
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 1, 2023
@cchengleo
Copy link
Contributor

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2023
Copy link
Contributor

@agradouski agradouski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agradouski, yuanchen8911

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit 54ac76b into kubernetes-sigs:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants