-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove kube-rbac-proxy #222
Conversation
/cc @cchengleo |
Pull Request Test Coverage Report for Build 4057721529
💛 - Coveralls |
Remove kube-rbac-proxy from kubevirtci
/cc @agradouski |
/ok-to-test |
/LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agradouski, yuanchen8911 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Following the upstream
cluster-api
instruction, remove unneeded component kube-rbac-proxy.Which issue this PR fixes
Remove uneeded
kube-rbac-proxy
.cluster-api
PR: ⚠️ Remove kube-rbac-proxy and expose metrics on localhost:8080 cluster-api#4640cluster-api
book: https://cluster-api.sigs.k8s.io/developer/providers/v0.3-to-v0.4.html#required-kustomize-changes-to-remove-kube-rbac-proxySpecial notes for your reviewer:
Tested the changes locally to bring up
capi
controller managers andcapk
controller managers.Release notes: