Add the ginkgolinter and fix findings #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
cncf-cla: yes
Pull Request Test Coverage Report for Build 4181316724
💛 - Coveralls |
nunnatsa
force-pushed
the
improve-linter
branch
from
cf0e5d4
to
1755441
Compare
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
nunnatsa
force-pushed
the
improve-linter
branch
5 times, most recently
from
eb97cb1
to
7680733
Compare
davidvossel
reviewed
Feb 14, 2023
Comment on lines
-115
to
127
| Eventually(func() error { | ||
| Eventually(func(g Gomega) { | ||
| machineList := &infrav1.KubevirtMachineList{} | ||
| err := k8sclient.List(context.Background(), machineList, client.InNamespace(namespace)) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| g.Expect( | ||
| k8sclient.List(context.Background(), machineList, client.InNamespace(namespace)), | ||
| ).To(Succeed()) | ||
|
|
||
| if len(machineList.Items) == 0 { | ||
| return fmt.Errorf("expecting a non-empty list of machines") | ||
| } | ||
| g.Expect(machineList.Items).ToNot(BeEmpty(), "expecting a non-empty list of machines") | ||
|
|
||
| for _, machine := range machineList.Items { | ||
| if !conditions.IsTrue(&machine, infrav1.BootstrapExecSucceededCondition) { | ||
| return fmt.Errorf("still waiting on a kubevirt machine with bootstrap succeeded condition") | ||
| } | ||
| g.Expect(conditions.IsTrue(&machine, infrav1.BootstrapExecSucceededCondition)).To( | ||
| BeTrue(), | ||
| "still waiting on a kubevirt machine with bootstrap succeeded condition", | ||
| ) | ||
| } |
There was a problem hiding this comment.
We're waiting to "eventually" have this loop pass without errors. By introducing the g.Expect logic in this loop, will the eventually loop still be eventually consistent once no errors are encountered?
There was a problem hiding this comment.
|
/retest |
In addition to the ginkgo linter findings, replace this pattern: ```go err = funcRetErr() Expect(err).ToNot(HaveOccurred()) ``` With the more readable version of: ```go Expect(funcRetErr()).To(Succeed()) ``` Improve some Eventually usages by using the Gomega parameter instead of returning error, to get cleaner test code. Also, replaced some deprecation methods. Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
nunnatsa
force-pushed
the
improve-linter
branch
from
7680733
to
c5ff039
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidvossel, nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the ginkgo linter findings, replace this pattern:
With the more readable version of:
Improve some
Eventuallyusages by using the Gomega parameter instead of returning error, to get cleaner test code.Also, replaced some deprecation methods.
Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release notes: