-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix namespace/cluster name on templates. #244
Conversation
1. ConfigMap had Provider config pointing to kvcluster namespace instead of cluster namespace. 2. Deployment was looking for cluster named kvcluster instead of actual cluster name.
1. ConfigMap had Provider config pointing to kvcluster namespace instead of actual cluster namespace. 2. Deployment was looking for cluster kvcluster instead of actual cluster name.
1. ConfigMap config for Provider was looking for kvcluster namespace instead of actual cluster namespace. 2. Deployment was looking for kvcluster instead of actual cluster name.
1. Configmap data for Provider was looking for kvcluster namespace instead of actual cluster namespace. 2. Deployment is looking for kvcluster cluster instead of actual cluster name.
Welcome @feitnomore! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feitnomore, qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: The templates provided have some caveats regarding cluster name and namespace.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes # N/ASpecial notes for your reviewer: I was trying those templates and took a time to figure out the substitutions I had to perform here.