Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespace/cluster name on templates. #244

Merged
merged 4 commits into from
Jun 29, 2023

Conversation

feitnomore
Copy link
Contributor

What this PR does / why we need it: The templates provided have some caveats regarding cluster name and namespace.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes # N/A

Special notes for your reviewer: I was trying those templates and took a time to figure out the substitutions I had to perform here.

1. ConfigMap had Provider config pointing to kvcluster namespace instead of cluster namespace.
2. Deployment was looking for cluster named kvcluster instead of actual cluster name.
1. ConfigMap had Provider config pointing to kvcluster namespace instead of actual cluster namespace.
2. Deployment was looking for cluster kvcluster instead of actual cluster name.
1. ConfigMap config for Provider was looking for kvcluster namespace instead of actual cluster namespace.
2. Deployment was looking for kvcluster instead of actual cluster name.
1. Configmap data for Provider was looking for kvcluster namespace instead of actual cluster namespace.
2. Deployment is looking for kvcluster cluster instead of actual cluster name.
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 24, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @feitnomore!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-kubevirt 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-kubevirt has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@feitnomore feitnomore marked this pull request as ready for review June 24, 2023 14:00
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 24, 2023
@qinqon
Copy link
Contributor

qinqon commented Jun 29, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feitnomore, qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit d446182 into kubernetes-sigs:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants