Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic Markdown Fix #262

Merged
merged 1 commit into from
Aug 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ We also encourage ALL active community participants to act as if they are mainta
- Participate in the conversations on [Kubernetes Discuss](https://discuss.kubernetes.io/c/contributors/cluster-api/23)

- **Meetings:**
- Cluster API Provider KubeVirt Syncup Meetings: [Tuesdays at 8:00 PT (Pacific Time)](https://zoom.us/j/94685513559?pwd=cnI3RUQyZ3RrckpOc1BQNDA1Q1BrZz09) (weekly starting Tuesday December 7th, 2021). [Convert to your timezone](http://www.thetimezoneconverter.com/?t=8:00&tz=PT%20%28Pacific%20Time%29).
- Cluster API Provider KubeVirt Syncup Meetings: [Tuesdays at 8:00 PT (Pacific Time)](https://zoom.us/j/94685513559?pwd=cnI3RUQyZ3RrckpOc1BQNDA1Q1BrZz09) (weekly starting Tuesday, December 7th, 2021). [Convert to your timezone](http://www.thetimezoneconverter.com/?t=8:00&tz=PT%20%28Pacific%20Time%29).
- [Meeting notes and Agenda](https://docs.google.com/document/d/1ZAnRLCKOVbDqrsrYis2OR0aZIAlqp576gCJVCkMNiHM/edit?usp=sharing).

### Other ways to communicate with the maintainers
Expand All @@ -44,15 +44,15 @@ If you think you have found a bug please follow the instruction below.
- Please give a small amount of time giving due diligence to the issue tracker. Your issue might be a duplicate.
- Get the logs from the custom controllers and please paste them in the issue.
- Open a bug report.
- Remember users might be searching the issue in future, so please make sure to give it a meaningful title to help others.
- Remember users might be searching the issue in the future, so please make sure to give it a meaningful title to help others.
- Feel free to reach out to the community on slack.

### Tracking new feature

We also have a issue tracker to track features. If you think you have a feature idea, that could make Cluster API provider Kubevirt become even more awesome, then follow these steps.
We also have an issue tracker to track features. If you think you have a feature idea, that could make Cluster API provider Kubevirt become even more awesome, then follow these steps.

- Open a feature request
- Remember users might be searching for the issue in future, so please make sure to give it a meaningful title to help others.
- Remember users might be searching for the issue in the future, so please make sure to give it a meaningful title to help others.
- Clearly define the use case with concrete examples. Example: type `this` and cluster-api-provider-kubevirt does `that`.
- Some of our larger features will require some design. If you would like to include a technical design to your feature, please go ahead.
- After the new feature is well understood, and the design is agreed upon we can start coding the feature. We would love for you to code it. So please open up a **WIP** *(work in progress)* PR and happy coding!
Expand Down
2 changes: 1 addition & 1 deletion controllers/kubevirtcluster_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ func (r *KubevirtClusterReconciler) Reconcile(goctx gocontext.Context, req ctrl.
}
}()

// Add finalizer first if does not exist to avoid the race condition between init and delete
// Add finalizer first if it does not exist to avoid the race condition between init and delete
if !controllerutil.ContainsFinalizer(kubevirtCluster, infrav1.ClusterFinalizer) {
controllerutil.AddFinalizer(kubevirtCluster, infrav1.ClusterFinalizer)
return ctrl.Result{}, nil
Expand Down
2 changes: 1 addition & 1 deletion pkg/kubevirt/machine.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ func NewMachine(ctx *context.MachineContext, client client.Client, namespace str
return machine, nil
}

// IsTerminal Reports back if the VM is either being requested to terminate or is terminate
// IsTerminal Reports back if the VM is either being requested to terminate or is terminated
// in a way that it will never recover from.
func (m *Machine) IsTerminal() (bool, string, error) {
if m.vmInstance == nil || m.vmiInstance == nil {
Expand Down
Loading