Bump k8s.io/client-go to v0.28.2

[bryan-cox]

What this PR does / why we need it:
Bump k8s.io/client-go to v0.28.2

[k8s-ci-robot]

Welcome @bryan-cox!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-kubevirt 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-kubevirt has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[nunnatsa]

/ok-to-test

[coveralls]

Pull Request Test Coverage Report for Build 6815711612

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 61.992%

---

Totals
Change from base Build 6590293017:	0.0%
Covered Lines:	946
Relevant Lines:	1526

---

💛 - Coveralls

[davidvossel]

can this bump be done without including the vendor dir? make modules is what we usually run after modifying the go.mod file.

[nunnatsa]

LGTM in general. One question - do we want to bump everything to v0.28.3? I think it fixes the http2 CVE.

[bryan-cox]

LGTM in general. One question - do we want to bump everything to v0.28.3? I think it fixes the http2 CVE.

Yeah it looks like it - https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.28.md#changelog-since-v1282

I'll bump things up.

[bryan-cox]

/test ?

[k8s-ci-robot]

@bryan-cox: No presubmit jobs available for kubernetes-sigs/cluster-api-provider-kubevirt@main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bryan-cox]

/retest

[nunnatsa]

Closing and reopening

[davidvossel]

i re-kicked off the e2e tests

[davidvossel]

e2e tests are failing due to a go mod change.

go: updates to go.mod needed; to update it:
	go mod tidy
make[1]: *** [Makefile:106: build-e2e-test] Error 1

i guess run go mod tidy? maybe something needs to be updated

[bryan-cox]

e2e tests are failing due to a go mod change.

go: updates to go.mod needed; to update it:
	go mod tidy
make[1]: *** [Makefile:106: build-e2e-test] Error 1

i guess run go mod tidy? maybe something needs to be updated

Ok, I did that and it updated the go.mod in the e2e directory. Weird, I thought make modules ran go mod tidy already.

[nunnatsa]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nunnatsa]

/lgtm