Remove e2e/go.mod #288
Remove e2e/go.mod #288
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/XXL
Pull Request Test Coverage Report for Build 9395559512Details
💛 - Coveralls |
Makefile
Outdated
| generate-kv-go-client: $(CLIENT_GEN) ## Generate kubevirt client-go for e2e | ||
| $(CLIENT_GEN) \ | ||
| --input-base="kubevirt.io/api" \ | ||
| --input="core/v1" \ | ||
| --output-pkg="sigs.k8s.io/cluster-api-provider-kubevirt/e2e/generated/client-go/clientset" \ | ||
| --clientset-name="versioned" \ | ||
| --output-dir /home/nunnatsa/GIT/cluster-api-provider-kubevirt/e2e/generated/client-go/clientset \ | ||
| --fake-clientset=false | ||
|
|
There was a problem hiding this comment.
do we need the kubevirt client once you transition e2e to use virtctl?
There was a problem hiding this comment.
I'll remove kv client. this is still WIP.
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
nunnatsa
force-pushed
the
gen-client
branch
6 times, most recently
from
1c59fab
to
e11f677
Compare
Makefile
Outdated
| @@ -225,7 +225,7 @@ docker-build: docker-pull-prerequisites ## Build the docker image for controller | |||
|
|
|||
| .PHONY: docker-push | |||
| docker-push: ## Push the docker image | |||
| docker push $(CONTROLLER_IMG)-$(ARCH):$(TAG) | |||
| docker push --tls-verify=false $(CONTROLLER_IMG)-$(ARCH):$(TAG) | |||
There was a problem hiding this comment.
we probably don't want to commit this change
There was a problem hiding this comment.
I am assuming you added this for when pushing to a repo that doesn't have a proper signed cert. What I did in HPP is make it an argument something like this:
TLS_VERIFY?=true
...
docker push -tls-verify=${TLS_VERIFY} $(CONTROLLER_IMG)-$(ARCH):$(TAG)
This way if you are testing locally you can just export TLS_VERIFY=false and it works. But it defaults to true.
|
/retest |
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
e2e/go.mod was added to split the e2e into a new module, to allow using older k8s packages in e2e tests, because the new k8s packages conflicted with the KubeVirt go-client.
This PR replaces the KV go-client with a the kubernetes client, and so it is now possible to use the newest k8s packages, and in general, the same packages as the application uses.
Also made some smaller fixes and improvements in the e2e tests, related to contexes and assertions.
Release notes: