Allow e2e multiple times #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
size/XXL
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
One of the e2e tests creates a secret that is not get deleted at the end of the test. When running the test again, it fails on secret re-creation. This commit fixes the issue by deleting the secret at the end of each test. Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
nunnatsa
force-pushed
the
allow-e2e-multiple-times
branch
from
0f06369
to
c8542fe
Compare
Pull Request Test Coverage Report for Build 9399394849Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9399423883Details
💛 - Coveralls |
|
/cc @davidvossel |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidvossel, nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the e2e tests creates a secret that is not get deleted at the end
of the test. When running the test again, it fails on secret
re-creation.
This commit fixes the issue by deleting the secret at the end of each
test.
Release notes: