-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix docker version issue. #270
fix docker version issue. #270
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: morvencao If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @morvencao. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test FYI @jichenjc |
ok, seems reasonable ,thanks for sharing~ |
Is this a thing any more? I am able to create new machines with Ubuntu 16.04 and 18.04. Both come up with the latest docker version.
|
I actually hit some issue yesterday on 18.04 , it tells me docker version doesn't not support 18.09 |
I can try tomorrow again and see whether same issue still there |
@morvencao Can you try latest build? @jichenjc has upgraded Kubernetes to 1.14.0 and it should works. |
@gyliu513 Thanks, let me give it a try. |
/lgtm cancel @morvencao please close this one if installation goes well. |
@morvencao so the latest |
Got It doesn't look like docker version issue now. BTW, the version of provisioned cluster is v1.14. |
What this PR does / why we need it:
In ubuntu, the latest docker version(
18.09
) is incompatible withkubeadm
, resultinguser-data
executing failure. See: kubernetes/minikube#3323/cc @gyliu513 @xunpan