Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create make commands for the operator #4122

Closed
wfernandes opened this issue Jan 25, 2021 · 7 comments · Fixed by #4126
Closed

Create make commands for the operator #4122

wfernandes opened this issue Jan 25, 2021 · 7 comments · Fixed by #4126
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Milestone

Comments

@wfernandes
Copy link
Contributor

User Story

As a CAPI developer, I would like to have convenient make commands to build the operator, generate manifests, and build docker images.

Detailed Description
Some of the commands are below but not limited to

# Build the binary 
make operator 
# Generate go related go
make generate-go-operator
# Generate manifests for the operator
make generate-operator-manifests
# Build and push docker images
make docker-build-operator
make docker-push-operator-manifest

# Modify the following
make release
make release-manifests

/kind feature
/area api
/area operator

@k8s-ci-robot
Copy link
Contributor

@wfernandes: The label(s) area/operator cannot be applied, because the repository doesn't have them

In response to this:

User Story

As a CAPI developer, I would like to have convenient make commands to build the operator, generate manifests, and build docker images.

Detailed Description
Some of the commands are below but not limited to

# Build the binary 
make operator 
# Generate go related go
make generate-go-operator
# Generate manifests for the operator
make generate-operator-manifests
# Build and push docker images
make docker-build-operator
make docker-push-operator-manifest

# Modify the following
make release
make release-manifests

/kind feature
/area api
/area operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/api Issues or PRs related to the APIs labels Jan 25, 2021
@wfernandes
Copy link
Contributor Author

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jan 25, 2021
@fabriziopandini
Copy link
Member

What about modifying also make generate-go and make generate-manifests

@wfernandes
Copy link
Contributor Author

Yup...Doing that as well. 🙂 Forgot to put that in. Thanks for calling it out though

@fabriziopandini
Copy link
Member

/remove-area api
/area operator
/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Mar 5, 2021
@k8s-ci-robot k8s-ci-robot added area/operator and removed area/api Issues or PRs related to the APIs labels Mar 5, 2021
@alexander-demicev
Copy link
Contributor

/close
Fixed by #4126

@k8s-ci-robot
Copy link
Contributor

@alexander-demichev: Closing this issue.

In response to this:

/close
Fixed by #4126

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants