-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider dropping MachinePools from ClusterClass self-hosted tests #9656
Comments
/triage accepted |
I don't think this is true, there is a MachinePools test in the framework |
Thanks for catching that - bad searching on my part - updated the issue to be more accurate. |
/assign @nawazkh /assign @adilGhaffarDev |
@killianmuldoon: GitHub didn't allow me to assign the following users: adilGhaffarDev. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We shouldn't need to do this now that #8842 has merged. Let's keep monitoring the signal in the next few days and close this issue if we don't see the flake anymore. |
/close |
@nawazkh: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We should consider dropping MachinePools from the self-hosted ClusterClass tests in order to stabilize the signal ahead of the release of v1.6.0 on November 28th.
As described in #9522 the self-hosted
ClusterClass
tests are very flaky on themain
branch of Cluster API. These tests are much more stable onrelease-1.4
andrelease-1.5
.At least some of the flakiness in the self-hosted tests is down to the addition of
MachinePools
to a number of test templates in #9393. There's a bug in theDockerMachinePool
implementation - #9655 - that causes CAPI components in a self-hosted cluster using MachinePools to become unstable.I don't think this new bug was introduced in the 1.6 release cycle. Before introducing MachinePools in ClusterClass there is only one e2e tests covering MachinePools - covering creation, scaling and deletion. There was no coverage for self-hosted Clusters using MachinePools.
In my view if these tests aren't stable on main by the publication of CAPI 1.6.0-rc.0, due to be published on 14th November, we should drop this test case from the release branch. We should maintain the tests on main with a view to fixing them, and if possible backporting the fixes.
The text was updated successfully, but these errors were encountered: