✨ Refactor template cloning for future use with kubeadmcontrolplane #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/assign @chuckha |
k8s-ci-robot
added
the
size/L
detiber
force-pushed
the
utilInjection
branch
2 times, most recently
from
f035616
to
299d061
Compare
- Use CloneTemplate through an interface for easier testing - Return an ObjectReference to the cloned resource rather than the resource itself - Add tests for template cloning
detiber
force-pushed
the
utilInjection
branch
from
299d061
to
1815a45
Compare
chuckha
approved these changes
Dec 23, 2019
k8s-ci-robot
added
the
lgtm
vincepri
reviewed
Dec 28, 2019
| @@ -46,8 +49,10 @@ func Get(ctx context.Context, c client.Client, ref *corev1.ObjectReference, name | |||
| return obj, nil | |||
| } | |||
|
|
|||
| type TemplateCloner struct{} | |||
There was a problem hiding this comment.
We need to add some documentation in the v1a2->v1a3 docs about this change, given that it might be used elsewhere
| // CloneTemplate uses the client and the reference to create a new object from the template. | ||
| func CloneTemplate(ctx context.Context, c client.Client, ref *corev1.ObjectReference, namespace string) (*unstructured.Unstructured, error) { | ||
| func (tc *TemplateCloner) CloneTemplate(ctx context.Context, c client.Client, ref *corev1.ObjectReference, namespace, clusterName string, owner *metav1.OwnerReference) (*corev1.ObjectReference, error) { |
There was a problem hiding this comment.
I wonder if the list of arguments needs to be simplified in a struct in a future PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: