🏃 refactor the etcd client in the cluster object #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-cluster-api-capd-e2e |
vincepri
reviewed
Feb 27, 2020
Signed-off-by: Chuck Ha <chuckh@vmware.com>
chuckha
force-pushed
the
cluster-etcd-client
branch
from
1c60349
to
b7752c9
Compare
k8s-ci-robot
added
the
lgtm
|
Oh, nice! The cert generation also seems to be one of the slower/more expensive parts of the health checking, and this definitely opens the door to helping with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chuck Ha chuckh@vmware.com
What this PR does / why we need it:
This starts improving the cluster abstraction. I believe this cleans up the constant client cert generation by only generating one bundle and reusing that.
This is related to the various error issues we have open. This should start to refactor some code to make it easier to test.
Related to #2454 and #2455