Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 test/e2e: Add v1.0=>main clusterctl upgrade test #8072

Merged
merged 1 commit into from
Feb 12, 2023
Merged

🌱 test/e2e: Add v1.0=>main clusterctl upgrade test #8072

merged 1 commit into from
Feb 12, 2023

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #8038

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 6, 2023
@sbueringer sbueringer mentioned this pull request Feb 6, 2023
Closed
18 tasks
jackfrancis
jackfrancis reviewed Feb 6, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member Author

test ?

@sbueringer
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-test-mink8s-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main
  • /test pull-cluster-api-e2e-full-main
  • /test pull-cluster-api-e2e-informing-ipv6-main
  • /test pull-cluster-api-e2e-informing-main
  • /test pull-cluster-api-e2e-workload-upgrade-1-26-latest-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-informing-ipv6-main
  • pull-cluster-api-e2e-informing-main
  • pull-cluster-api-e2e-main
  • pull-cluster-api-test-main
  • pull-cluster-api-test-mink8s-main
  • pull-cluster-api-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer force-pushed the pr-clusterctl-upgrade-1.0 branch 2 times, most recently from 78d26cc to d0d88a4 Compare February 6, 2023 18:56
@sbueringer sbueringer changed the title 🌱 test/e2e: Add v1.0=>main clusterctl upgrade test [WIP] 🌱 test/e2e: Add v1.0=>main clusterctl upgrade test Feb 6, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2023
@sbueringer
Copy link
Member Author

WIP => Have to trial-and-error e2e tests a bit

/test pull-cluster-api-e2e-full-main

@sbueringer
test/e2e: Add v1.0=>main clusterctl upgrade test
187e416 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer sbueringer force-pushed the pr-clusterctl-upgrade-1.0 branch from d0d88a4 to 187e416 Compare February 6, 2023 19:02
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member Author

/retest

1 similar comment
@sbueringer
Copy link
Member Author

/retest

@sbueringer sbueringer changed the title [WIP] 🌱 test/e2e: Add v1.0=>main clusterctl upgrade test 🌱 test/e2e: Add v1.0=>main clusterctl upgrade test Feb 7, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2023
killianmuldoon
killianmuldoon approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9a2746ca759b79f4e41febd4866bd149c1c22a1b

@sbueringer
Copy link
Member Author

Given lgtm above + it's a straightforward change

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit eae0775 into kubernetes-sigs:main Feb 12, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Feb 12, 2023
@sbueringer sbueringer deleted the pr-clusterctl-upgrade-1.0 branch February 12, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis jackfrancis left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@sbueringer @k8s-ci-robot @jackfrancis @killianmuldoon