Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Stop serving v1alpha4 API Versions #8996

Merged
merged 1 commit into from
Jul 13, 2023
Merged

⚠️ Stop serving v1alpha4 API Versions #8996

merged 1 commit into from
Jul 13, 2023

Conversation

killianmuldoon
Copy link
Contributor

@killianmuldoon killianmuldoon commented Jul 12, 2023 •
edited by sbueringer
Loading

Set served: false on v1alpha4 API types in:

  • api
  • controlplane/kubeadm/api
  • booststrap/kubeadm/api
  • test/infrastructure/docker/api
  • test/infrastructure/docker/exp/api
  • exp/addons/api
  • exp/api

Part of #8038

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 12, 2023
@killianmuldoon killianmuldoon changed the title 🌱 Stop serving v1alpha4 API Versions ⚠️ : Stop serving v1alpha4 API Versions Jul 12, 2023
@killianmuldoon killianmuldoon changed the title ⚠️ : Stop serving v1alpha4 API Versions ⚠️ Stop serving v1alpha4 API Versions Jul 12, 2023
@killianmuldoon killianmuldoon force-pushed the pr-stop-serving-v1alpha4 branch 3 times, most recently from cecc51b to 78b0e0b Compare July 12, 2023 17:03
sbueringer
sbueringer reviewed Jul 13, 2023
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nits.

I assume this PR is basically the same as the one we did for v1alpha3

test/e2e/config/docker.yaml Show resolved Hide resolved
test/e2e/data/infrastructure-docker/README.md Show resolved Hide resolved
@killianmuldoon
Stop serving v1alpha4 API Versions
acffb87 
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@killianmuldoon killianmuldoon force-pushed the pr-stop-serving-v1alpha4 branch from 78b0e0b to acffb87 Compare July 13, 2023 15:29
@g-gaston
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a51995d5340f91e72ae034bbee8fb7891923ef5d

@sbueringer
Copy link
Member

Thx!!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6acff21 into kubernetes-sigs:main Jul 13, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Jul 13, 2023
@killianmuldoon
Copy link
Contributor Author

/area api

@k8s-ci-robot k8s-ci-robot added the area/api Issues or PRs related to the APIs label Jul 24, 2023
@furkatgofurov7 furkatgofurov7 mentioned this pull request Aug 7, 2023
Closed
29 tasks
@kashifest kashifest mentioned this pull request Dec 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@g-gaston g-gaston Awaiting requested review from g-gaston

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@g-gaston g-gaston

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Issues or PRs related to the APIs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
4 participants
@killianmuldoon @g-gaston @k8s-ci-robot @sbueringer