-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Move internal.labels
to format
package for use by providers
#9002
Conversation
Opened a PR against your branch to fix the circular dependency: Jont828#1 |
internal.labels
package to util
for use by providersinternal.labels
package to util
for use by providers
I'm not sure if that technically falls under our backport guidelines post code freeze but I think it 100% makes sense to cherry-pick this into release-1.5. With the MPM implemention we advice InfraMachinePool implementers to use thoes utils, but this will only be possible if the utils are actually public. So I guess we can consider this sort of a bug fix. /cherry-pick release-1.5 |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm approve pending squash |
LGTM label has been added. Git tree hash: 22d41546017ca914eed2318609d162b0ad612408
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Also fine with this being made available in v1.5.
internal.labels
package to util
for use by providersinternal.labels
to format
package for use by providers
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
LGTM label has been added. Git tree hash: 03aba9c66508bbbf6341181d05d432a743d970a7
|
@sbueringer: new pull request created: #9006 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/area api |
/area util |
What this PR does / why we need it: We need
capilabels.MustFormatValue()
to be available for providers implementing MachinePool Machines.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #