Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Replacing gomega.Equal with gomega.BeComparableTo #9015

Merged
merged 1 commit into from
Aug 18, 2023
Merged

🌱 Replacing gomega.Equal with gomega.BeComparableTo #9015

merged 1 commit into from
Aug 18, 2023

Conversation

Dhairya-Arora01
Copy link
Contributor

What this PR does / why we need it:
Replacing gomega.Equal with BeComparableTo as Equal dumps both the values when comparing for equality in case the assertion fails. BeComparableTo tries to show the diff output which is more relevant while working with large structs. In this PR BeComparableTo is used only while comparing structs as gomega.Equal is fine while comparing small values as discussed in #8095

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #8095

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 19, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Dhairya-Arora01. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Dhairya-Arora01
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2023
killianmuldoon
killianmuldoon reviewed Jul 19, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 19, 2023
@Dhairya-Arora01
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2023
@vincepri
Copy link
Member

squash commits?

@Dhairya-Arora01
Copy link
Contributor Author

squash commits?

oh! sorry about that

vincepri
vincepri approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 15a527f6466d27201b7222817d559ecf42b56130

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2023
@sbueringer
Copy link
Member

@Dhairya-Arora01 Sorry for the delayed response. Can you please rebase? I'll try to review soon after

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2023
@k8s-ci-robot k8s-ci-robot requested a review from vincepri August 18, 2023 09:26
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2023
@sbueringer
Copy link
Member

Thx!

/lgtm

Waiting with approve until #8939 is merged to avoid further rebases on #8939

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b13a023ccd83c5d87a56e0d25353540612aaad5a

@sbueringer
Copy link
Member

/approve

CI found a few issues in #8939 so let's go ahead

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit c79c7d3 into kubernetes-sigs:main Aug 18, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 18, 2023
@Dhairya-Arora01 Dhairya-Arora01 deleted the BeComparable branch August 18, 2023 09:55
@g-gaston
Copy link
Contributor

/area testing

@k8s-ci-robot k8s-ci-robot added the area/testing Issues or PRs related to testing label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@Jont828 Jont828 Awaiting requested review from Jont828

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@vincepri vincepri

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

Consider using ginkgo.BeComparableTo instead of ginkgo.Equal
6 participants
@Dhairya-Arora01 @k8s-ci-robot @vincepri @sbueringer @g-gaston @killianmuldoon