Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 hack/release-notes: ensure relase notes tool can be used for external projects again #9018

Merged
merged 1 commit into from
Jul 20, 2023
Merged

🐛 hack/release-notes: ensure relase notes tool can be used for external projects again #9018

merged 1 commit into from
Jul 20, 2023

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:
Ensures the release note tool can again be used by other projects (in my case CAPV)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 20, 2023
@sbueringer
Copy link
Member Author

/hold

want to verify if it works before merge

cc @killianmuldoon

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2023
@sbueringer sbueringer force-pushed the pr-fix-release-notes branch from 1d97ae3 to af40856 Compare July 20, 2023 10:46
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 20, 2023
@sbueringer sbueringer force-pushed the pr-fix-release-notes branch from af40856 to 40ae6bb Compare July 20, 2023 10:51
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 20, 2023
@sbueringer sbueringer changed the title 🐛 hack/release-notes: add repo flag 🐛 hack/release-notes: ensure relase notes tool can be used for external projects again Jul 20, 2023
chrischdi
chrischdi approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 948b660e170443b90e8d6d0617b9e75afd6f1cf7

This was referenced Jul 20, 2023
Merged
Closed
fabriziopandini
fabriziopandini reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small nit, otherwise lgtm

hack/tools/release/notes.go Outdated Show resolved Hide resolved
@killianmuldoon
Copy link
Contributor

/lgtm
/approve

/hold

Until you're happy with it.

@nawazkh we should add a task to #9008 to add a make tool target that builds the release-notes tool if not present and runs it with the expected args. We should also update this guidance in the release docs.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2023
@sbueringer
hack/release-notes: ensure relase notes tool can be used for external
94afcd4 
projects again

Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer sbueringer force-pushed the pr-fix-release-notes branch from 40ae6bb to 94afcd4 Compare July 20, 2023 16:17
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2023
@k8s-ci-robot k8s-ci-robot requested a review from chrischdi July 20, 2023 16:17
killianmuldoon
killianmuldoon reviewed Jul 20, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fc5b5d42e0b459aa2b594d898d3ce340498d9414

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member Author

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot
Copy link

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7399f5f into kubernetes-sigs:main Jul 20, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Jul 20, 2023
@sbueringer sbueringer deleted the pr-fix-release-notes branch July 20, 2023 18:10
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 20, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #9021

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor

/area release

@k8s-ci-robot k8s-ci-robot added the area/release Issues or PRs related to releasing label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@vincepri vincepri Awaiting requested review from vincepri

@chrischdi chrischdi Awaiting requested review from chrischdi

Assignees

@chrischdi chrischdi

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
6 participants
@sbueringer @k8s-ci-robot @killianmuldoon @k8s-infra-cherrypick-robot @chrischdi @fabriziopandini