-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 hack/observability: add capi_machine_status_certificatesexpirydate metric #9084
🌱 hack/observability: add capi_machine_status_certificatesexpirydate metric #9084
Conversation
@@ -87,6 +87,14 @@ | |||
address: | |||
- address | |||
type: Info | |||
- name: status_certificatesexpirydate | |||
help: Information about the node reference of a machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the help text sounds a bit wrong
44530a5
to
9402000
Compare
Let me know if I should take another look / it works :D |
Jep, should work now:
|
Thx! one nit |
9402000
to
f585a8c
Compare
Thx! /lgtm |
LGTM label has been added. Git tree hash: be07ed50dfef1f75fe441fad00e6da8fa21206c0
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area metrics |
What this PR does / why we need it:
Adds a gauge metric to our kube-state-metrics configuration for exposing a machines
.status.certificatesExpiryDate
.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #9019