Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Clarify release team vs k8s/k8s-SIGs org membership #9089

Merged
merged 1 commit into from
Aug 18, 2023
Merged

🌱 Clarify release team vs k8s/k8s-SIGs org membership #9089

merged 1 commit into from
Aug 18, 2023

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Follow up on some recent discussions in Slack (https://kubernetes.slack.com/archives/C8TSNPY4T/p1690529653678859)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 29, 2023
furkatgofurov7
furkatgofurov7 reviewed Jul 30, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying the membership part, this was missing from the document as over time we realised it! Few nits and one suggestion from my side:

docs/release/release-team.md Outdated Show resolved Hide resolved
docs/release/release-team.md Outdated Show resolved Hide resolved
docs/release/release-team.md Outdated Show resolved Hide resolved
@fabriziopandini fabriziopandini force-pushed the clarify-release-team-vs-k8s-org-membership branch from 16f81ed to fc52c01 Compare August 17, 2023 16:47
@fabriziopandini fabriziopandini force-pushed the clarify-release-team-vs-k8s-org-membership branch from fc52c01 to d78d961 Compare August 17, 2023 19:19
furkatgofurov7
furkatgofurov7 reviewed Aug 17, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

/lgtm
@kubernetes-sigs/cluster-api-release-team

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7210cff2849969d0508956e3200294cb7276bcfc

@nawazkh
Copy link
Member

nawazkh commented Aug 17, 2023

/lgtm

killianmuldoon
killianmuldoon reviewed Aug 17, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@g-gaston
Copy link
Contributor

/lgtm

mjlshen
mjlshen approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@mjlshen mjlshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

killianmuldoon
killianmuldoon reviewed Aug 18, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6175a4d into kubernetes-sigs:main Aug 18, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 18, 2023
@g-gaston
Copy link
Contributor

/area release

@k8s-ci-robot k8s-ci-robot added the area/release Issues or PRs related to releasing label Oct 23, 2023
@fabriziopandini fabriziopandini deleted the clarify-release-team-vs-k8s-org-membership branch November 17, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@mjlshen mjlshen mjlshen approved these changes

@joekr joekr Awaiting requested review from joekr

@sbueringer sbueringer Awaiting requested review from sbueringer

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@ykakarap ykakarap Awaiting requested review from ykakarap

Assignees

@mjlshen mjlshen

@g-gaston g-gaston

@nawazkh nawazkh

@furkatgofurov7 furkatgofurov7

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
7 participants
@fabriziopandini @k8s-ci-robot @nawazkh @g-gaston @mjlshen @furkatgofurov7 @killianmuldoon