🌱 Add test for required properties in clusterclass variables #9113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
killianmuldoon
commented
Aug 3, 2023
internal/topology/variables/clusterclass_variable_validation_test.go
Outdated
Show resolved
Hide resolved
killianmuldoon
force-pushed
the
pr-required-properties
branch
from
f87369b to
25d331c
Compare
killianmuldoon
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/area testing |
sbueringer
reviewed
Aug 15, 2023
internal/topology/variables/clusterclass_variable_validation_test.go
Outdated
Show resolved
Hide resolved
internal/topology/variables/clusterclass_variable_validation_test.go
Outdated
Show resolved
Hide resolved
sbueringer
reviewed
Aug 15, 2023
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
killianmuldoon
force-pushed
the
pr-required-properties
branch
from
25d331c to
1b7b56e
Compare
|
/lgtm Thank you |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 46cb741291b8955b7eedfff6275ff246e077a364
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test to document the current behaviour of defaulting required fields below properties in ClusterClass variables.
Related to a slack discussion at https://kubernetes.slack.com/archives/C8TSNPY4T/p1690560631268189