-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Document new scheme-builder patterns in provider migration doc #9146
📖 Document new scheme-builder patterns in provider migration doc #9146
Conversation
/assign @vincepri |
/lgtm |
LGTM label has been added. Git tree hash: c91da8c98c8401b46882a5d018d13604c286284a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of replicating the info here could this just be a short note and a link to where this is fully documented?
@killianmuldoon I am fine with this suggestion as well. Do I understand correctly, in that case I can also drop the diff go code changes that I currently have or leave it? |
I've added a note with a suggestion of how I think this should look - please check the link though as I didn't verify it. |
a763a5e
to
ba8019d
Compare
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
ba8019d
to
f447127
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: bed23d548e9cb9414e53fc27d99887e2296704ba
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Documents changes from #9045 in v1.5-v1.6 migration document
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):xref comment: #9045 (comment)