🌱 Drop duplicate pprof and unused linter excludes #9156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 65bc07174a8f526fa8df9aac0af2c4a1c46f4c74
|
|
Thanks for catching this! |
k8s-ci-robot
added
the
approved
chrischdi
force-pushed
the
pr-lint-pprof
branch
from
d3b772c to
3ed6ef7
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
size/S
|
JIT, sorry @killianmuldoon , I did find another improvement :-) |
|
/hold If I have some more /retitle [WIP] 🌱 Drop duplicate pprof and unused linter excludes |
k8s-ci-robot
changed the title
k8s-ci-robot
added
do-not-merge/hold
chrischdi
force-pushed
the
pr-lint-pprof
branch
from
3ed6ef7 to
eaa43d4
Compare
|
That should be it /hold cancel /retitle 🌱 Drop duplicate pprof and unused linter excludes |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d8fd3d23552f8c2061ff09974c928d3f208c40d6
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/area devtools |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Found this while syncing golangci-lint config with CAPV.
The pprof imports for the boostrap and control plane controller are a duplicate to the ones provided via controller-runtime.
The linter exclusions are not necessary anymore.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #