-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Reword and list which deployments have to be edited for exp features. #9173
📖 Reword and list which deployments have to be edited for exp features. #9173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
/lgtm
LGTM label has been added. Git tree hash: 1a052dd1ea941288e9d358b87acd428a0874698f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, nice improvement!
Just once suggestion
docs/book/src/tasks/experimental-features/experimental-features.md
Outdated
Show resolved
Hide resolved
docs/book/src/tasks/experimental-features/experimental-features.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! Could you squash the commits?
57fc2e8
to
59e99f3
Compare
docs/book/src/tasks/experimental-features/experimental-features.md
Outdated
Show resolved
Hide resolved
59e99f3
to
b6fb030
Compare
Thx! Also good to know this documentation exists. Will point folks there in the future, we're getting this asked often.. /lgtm |
LGTM label has been added. Git tree hash: d718e613e0b39b029b552fb1313a549b4dac09aa
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.5 |
@killianmuldoon: new pull request created: #9205 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This paragraph in the section describing describing the experimental features explains how to enable/disable features in a running mgmt cluster. Trying this for the
ClusterToplogy
feature flag revealed that the flag must also to be enabled for KCP. Otherwise the Webhook for KubeadmControlPlaneTemplate will deny the request. See: https://github.com/kubernetes-sigs/cluster-api/blob/main/controlplane/kubeadm/api/v1beta1/kubeadmcontrolplanetemplate_webhook.go#L59It might make sense for a user to get a list which deployments have to be edited for which feature. Not sure if this is the best way to communicate this or if this should rather be put into the corresponding sections of the experimental features. Up for suggestions 🙂.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
/area documentation
Johannes Frey <johannes.frey@mercedes-benz.com>, Mercedes-Benz Tech Innovation GmbH (Provider Information)