-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ machineset: adjust preflight check to allow kubelet version skew of 3 for clusters running v1.28 and above #9222
✨ machineset: adjust preflight check to allow kubelet version skew of 3 for clusters running v1.28 and above #9222
Conversation
/cherry-pick release-1.5 |
@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, just one nit
415be26
to
369d815
Compare
… for clusters running v1.28 and above
369d815
to
7394084
Compare
/lgtm |
LGTM label has been added. Git tree hash: c25d2204773477520695c2186d54fb17ad677e49
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@chrischdi: new pull request created: #9233 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
According to #8708 : Check and update the Kubernetes version skew policy in the MachineSet preflight checks.
This PR adjusts the machineset preflight checks to:
Allow minor version skew of 3 for kubelets, if the control plane is running kubernetes v1.28 and above.
See https://kubernetes.io/releases/version-skew-policy/#kubelet for more details.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
/area machineset