Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 test: pin conformance image to a version which includes a fix for the dualstack tests #9252

Merged
merged 1 commit into from
Aug 21, 2023
Merged

🐛 test: pin conformance image to a version which includes a fix for the dualstack tests #9252

merged 1 commit into from
Aug 21, 2023

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

Pins the container image used for kubernetes conformance tests in our dualstack tests to the version of commit: kubernetes/kubernetes@18290bfdc8f

This is to include the following fixes:

Note: this fixes are getting cherry-picked to kubernetes release-1.28 in:

And the introduced changes should get dropped when we bump to a newer version than v1.28.0 at

cluster-api/test/e2e/config/docker.yaml

Line 241 in d57f454

KUBERNETES_VERSION: "v1.28.0"

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9240

@chrischdi
Copy link
Member Author

/test help

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Aug 21, 2023
@k8s-ci-robot
Copy link
Contributor

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main
  • /test pull-cluster-api-e2e-full-dualstack-and-ipv6-main
  • /test pull-cluster-api-e2e-full-main
  • /test pull-cluster-api-e2e-informing-main
  • /test pull-cluster-api-e2e-mink8s-main
  • /test pull-cluster-api-e2e-scale-main-experimental
  • /test pull-cluster-api-e2e-workload-upgrade-1-28-latest-main
  • /test pull-cluster-api-test-mink8s-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-informing-main
  • pull-cluster-api-e2e-main
  • pull-cluster-api-test-main
  • pull-cluster-api-verify-main

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 21, 2023
@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-full-dualstack-and-ipv6-main

@chrischdi
Copy link
Member Author

/area e2e-testing

@k8s-ci-robot k8s-ci-robot added area/e2e-testing Issues or PRs related to e2e testing and removed do-not-merge/needs-area PR is missing an area label labels Aug 21, 2023
@sbueringer
Copy link
Member

In general lgtm. Thx for taking care of this!

killianmuldoon
killianmuldoon reviewed Aug 21, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e8388ff20b535a01d151155bc6190c1f510915d8

@killianmuldoon
Copy link
Contributor

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi chrischdi force-pushed the pr-dualstack-1.28.0-conformance-fix branch from d57f454 to 5493f59 Compare August 21, 2023 10:14
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2023
@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-full-dualstack-and-ipv6-main

@sbueringer
Copy link
Member

Thx!
/lgtm
/approve

/hold
for green CI

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d41f8791757807a4e12168d7a982521e9c2caac0

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2023
@chrischdi
Copy link
Member Author

CI is happy

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3f480f7 into kubernetes-sigs:main Aug 21, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 21, 2023
@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: new pull request created: #9256

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 21, 2023
Merged
killianmuldoon pushed a commit to killianmuldoon/cluster-api that referenced this pull request Aug 21, 2023
@k8s-ci-robot @killianmuldoon
Merge pull request kubernetes-sigs#9252 from chrischdi/pr-dualstack-1…
741c6c0 
….28.0-conformance-fix

🐛 test: pin conformance image to a version which includes a fix for the dualstack tests
@nawazkh nawazkh mentioned this pull request Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@richardcase richardcase Awaiting requested review from richardcase

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

Dualstack tests failing
5 participants
@chrischdi @k8s-ci-robot @sbueringer @killianmuldoon @k8s-infra-cherrypick-robot