Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Make ClusterClass generated object names consistent #9254

Merged
merged 1 commit into from
Aug 22, 2023
Merged

🌱 Make ClusterClass generated object names consistent #9254

merged 1 commit into from
Aug 22, 2023

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #9135

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 21, 2023
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member Author

cc @fabriziopandini

@sbueringer
Make ClusterClass generated object names consistent
7bc1644 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer sbueringer force-pushed the pr-cc-consistent-obj-names branch from 2706f3a to 7bc1644 Compare August 21, 2023 10:19
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 21, 2023
@chaunceyjiang
Copy link
Contributor

Just a question, if we directly modify the name, will there be any compatibility issues?

Not long ago, I also wanted to pick up this issue. However, I made the same modification but did not submit a pull request in the end because I was unsure if this modification would cause any compatibility issues.

killianmuldoon
killianmuldoon reviewed Aug 21, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area clusterclass

@k8s-ci-robot k8s-ci-robot added area/clusterclass Issues or PRs related to clusterclass and removed do-not-merge/needs-area PR is missing an area label labels Aug 21, 2023
@sbueringer
Copy link
Member Author

sbueringer commented Aug 21, 2023 •
edited
Loading

Just a question, if we directly modify the name, will there be any compatibility issues?

Not long ago, I also wanted to pick up this issue. However, I made the same modification but did not submit a pull request in the end because I was unsure if this modification would cause any compatibility issues.

There should be no compatibility issue. Do you mean during upgrades?

We only use those functions when we create the name of new objects. So existing objects are not affected in any way by this change.

Otherwise they would be already affected today as we always add a random suffix to the names :) (so the full name will be different in every reconcile anyway)

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer sbueringer mentioned this pull request Aug 21, 2023
Merged
4 tasks
@sbueringer
Copy link
Member Author

clusterctl upgrade is green and checked the test artifacts. Everything looks as expected

chrischdi
chrischdi reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1d84a5d87af30d648393a28b6337c38b1a19e8fb

@killianmuldoon
Copy link
Contributor

/lgtm

@killianmuldoon
Copy link
Contributor

/approve

/hold

(Feel free to unhold whenever you'd like)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2023
@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 937af16 into kubernetes-sigs:main Aug 22, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 22, 2023
@sbueringer sbueringer deleted the pr-cc-consistent-obj-names branch August 22, 2023 17:14
@chess-knight chess-knight mentioned this pull request Dec 6, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@chrischdi chrischdi chrischdi left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@chrischdi chrischdi

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@sbueringer @chaunceyjiang @k8s-ci-robot @killianmuldoon @chrischdi