-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 github: add edited and reopened as triggers for the GH workflow approval #9259
🌱 github: add edited and reopened as triggers for the GH workflow approval #9259
Conversation
/assign @sbueringer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for getting this fix in.
LGTM label has been added. Git tree hash: 5728747dc1aa24a20cbe6b29c40fd7826d2eb0e1
|
/approve let's give this a try |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I updated the description of this PR: #9251 manually and that correctly approved the workflow run and started the linter. Thanks! |
What this PR does / why we need it:
Adds the types
edited
andreopened
to the triggers for thePR approve GH Workflows
action.Before this PR the golangci-lint action could have been triggered by the
edited
orreopened
actions.The approval workflow would not get triggered in that case and did not approve the linter.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #9215
/area ci