-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Promote chrischdi to cluster-api reviewer #9286
🌱 Promote chrischdi to cluster-api reviewer #9286
Conversation
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
/lgtm
LGTM label has been added. Git tree hash: 6330890730d4b4c93d45441fb865489918ee1a87
|
/area documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big +1 from me
Thank you for all you have done so far and looking forward for more of your contributions!
/lgtm |
💯 /lgtm Thank you very much for all you work on core CAPI!!! |
+1 , thanks for the hard work Christian! |
A big 👍 from me /lgtm |
we are leaving this open for 1 week from today for lazy consensus. |
/lgtm +1 from my side as well, thank you @chrischdi for all your contributions so far! |
Thanks, @chrischdi for all your contributions! +1 |
/approve (Lazy consensus is until tomorrow) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Lazy consensus deadline expired. Congrats @chrischdi! And thx for volunteering to take over more responsibilities which basically means more work 😄 /hold cancel |
Thanks to everyone for the support! 😄 🎉 |
What this PR does / why we need it:
This PR adds @chrischdi (myself) to cluster-api-reviewers 🙂 🙃 .
I was added as reviewer back in January (#7996) for topology controller, CAPD and test*.
Since then I also took part in the release team for v1.5 as shadow for the
CI Signal/Bug triage/Automation Manager
sub-team where I especially worked on deflaking some of our e2e tests during that cycle.Besides that I contributed code for custom resource metrics for CAPI which got used e.g. for getting better insights for the scale testing (#8814) efforts.
By getting promoted to a reviewer of all parts in CAPI, I'd like to help the community to spread the work across more people.
To get a list of all my contributions to CAPI:
/cc @fabriziopandini @killianmuldoon @sbueringer
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #