Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 ginkgolinter: forbid focus container #9320

Merged
merged 1 commit into from
Aug 28, 2023
Merged

🌱 ginkgolinter: forbid focus container #9320

merged 1 commit into from
Aug 28, 2023

Conversation

nunnatsa
Copy link
Contributor

@nunnatsa nunnatsa commented Aug 28, 2023 •
edited
Loading

What this PR does / why we need it:
Enable the new ginkgolinter rule to disallow using of focus containers (e.g. FIt, FContext and so on). This will prevent leaking of debug code from a local debug environment to the code base.

See more info here: https://github.com/nunnatsa/ginkgolinter#focus-container--focus-individual-spec-found-bug

/area test
/area ci

@nunnatsa
ginkgolinter: forbid focus container
ad59639 
Enable the new ginkgolinter rule to disallow using of focus containers
(e.g. `FIt`, `FContext` and so on). This will prevent leaking of debug
code from a local debug environment to the code base.

See more info here: https://github.com/nunnatsa/ginkgolinter#focus-container--focus-individual-spec-found-bug

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@k8s-ci-robot
Copy link
Contributor

@nunnatsa: The label(s) area/runtime-test cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:
Enable the new ginkgolinter rule to disallow using of focus containers (e.g. FIt, FContext and so on). This will prevent leaking of debug code from a local debug environment to the code base.

See more info here: https://github.com/nunnatsa/ginkgolinter#focus-container--focus-individual-spec-found-bug

/area runtime-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 28, 2023
@nunnatsa
Copy link
Contributor Author

/area test
/area ci

@k8s-ci-robot k8s-ci-robot added the area/ci Issues or PRs related to ci label Aug 28, 2023
@k8s-ci-robot
Copy link
Contributor

@nunnatsa: The label(s) area/test cannot be applied, because the repository doesn't have them.

In response to this:

/area test
/area ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Aug 28, 2023
@nunnatsa nunnatsa mentioned this pull request Aug 28, 2023
Merged
@sbueringer sbueringer added the area/testing Issues or PRs related to testing label Aug 28, 2023
@sbueringer
Copy link
Member

/lgtm

/assign @killianmuldoon

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b7c59a0c6942dd1e341e74262f7d091685c8b38b

@nunnatsa
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 28, 2023
vincepri
vincepri approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit b183e66 into kubernetes-sigs:main Aug 28, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 28, 2023
@nunnatsa nunnatsa deleted the ginkgolinter-focus-container branch August 28, 2023 17:10
@g-gaston
Copy link
Contributor

/remove-area testing

@k8s-ci-robot k8s-ci-robot removed the area/testing Issues or PRs related to testing label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
6 participants
@nunnatsa @k8s-ci-robot @sbueringer @g-gaston @vincepri @killianmuldoon