Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add unit tests for CC MP blueprint, current_state, & desired_state #9348

Merged
merged 1 commit into from
Sep 21, 2023
Merged

🌱 Add unit tests for CC MP blueprint, current_state, & desired_state #9348

merged 1 commit into from
Sep 21, 2023

Conversation

willie-yao
Copy link
Contributor

What this PR does / why we need it:
This PR adds tests for the new ClusterClass MachinePool implementation for the following files:

  • internal/controllers/topology/cluster/blueprint_test.go
  • internal/controllers/topology/cluster/current_state_test.go
  • internal/controllers/topology/cluster/desired_state_test.go

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes part of #5991

/area testing

@k8s-ci-robot k8s-ci-robot added area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 31, 2023
@willie-yao
Copy link
Contributor Author

Note: Changes in builders will be dependent on #9346

@willie-yao willie-yao force-pushed the cc-mp-unit-tests branch 13 times, most recently from 05399c9 to 59ab14f Compare September 1, 2023 23:40
@killianmuldoon
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2023
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 5, 2023
@willie-yao willie-yao changed the title 🌱 WIP: Add unit tests for CC MP blueprint, current_state, & desired_state 🌱 Add unit tests for CC MP blueprint, current_state, & desired_state Sep 5, 2023
@sbueringer
Copy link
Member

/assign @chrischdi

@willie-yao willie-yao force-pushed the cc-mp-unit-tests branch 2 times, most recently from d4164a1 to d79e339 Compare September 12, 2023 20:33
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2023
@chrischdi
Copy link
Member

/lgtm

but requires rebase

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 547d283982b1054ccfeb84d89a12d0c67184c026

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2023
@sbueringer sbueringer mentioned this pull request Sep 19, 2023
Closed
39 tasks
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 21, 2023
@sbueringer
Copy link
Member

sbueringer commented Sep 21, 2023 •
edited
Loading

@willie-yao Thank you very much!!

Sorry for the late review. I heard you're out at the moment. As I'm on PTO starting tomorrow I just pushed another commit with a few fixes so we can merge the PR before I'm on PTO. I hope that's okay for you

@sbueringer
Copy link
Member

@chrischdi PTAL :)

chrischdi
chrischdi reviewed Sep 21, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes lgtm.

Requites squash?

@sbueringer
Copy link
Member

Done!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 21, 2023
@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f0bc026cecb88e8cbd033f43eeb7139b19e75137

@k8s-ci-robot k8s-ci-robot merged commit 332882b into kubernetes-sigs:main Sep 21, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@ykakarap ykakarap Awaiting requested review from ykakarap

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@willie-yao @killianmuldoon @sbueringer @chrischdi @k8s-ci-robot