🐛 Fix autoscaler image repo #9353
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
/assign @killianmuldoon @chrischdi |
k8s-ci-robot
added
do-not-merge/needs-area
|
/cherry-pick release-1.5 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-e2e-full-main Let's merge after e2e-full this time |
k8s-ci-robot
added
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: f81304fbae6795f547e7f455ff260a8b9d093c1d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
|
Looks to be faling because it doesn't have the RBAC to list MachinePools - https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/9353/pull-cluster-api-e2e-full-main/1697564669507538944/artifacts/clusters/autoscaler-v9mkfg/logs/cluster-autoscaler-system/cluster-autoscaler/cluster-autoscaler-585fd74b59-88hfr/cluster-autoscaler.log |
|
Thx, will fix! I think they implemented this between 1.26 and 1.28 |
Signed-off-by: Stefan Büringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-fix-autoscaler
branch
from
6f82954 to
9793a09
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
requested review from
chrischdi,
furkatgofurov7 and
killianmuldoon
| @@ -374,7 +374,7 @@ func getAuthenticationTokenForAutoscaler(ctx context.Context, managementClusterP | |||
| { | |||
| Verbs: []string{"get", "list", "update", "watch"}, | |||
| APIGroups: []string{"cluster.x-k8s.io"}, | |||
| Resources: []string{"machinedeployments", "machinedeployments/scale", "machines", "machinesets"}, | |||
| Resources: []string{"machinedeployments", "machinedeployments/scale", "machinepools", "machinepools/scale", "machines", "machinesets"}, | |||
There was a problem hiding this comment.
|
/test pull-cluster-api-e2e-full-main |
|
Added this test to the list of e2e tests we should extend as part of CC+MP support |
|
/test pull-cluster-api-e2e-full-main Didn't run the last time for some reason 🤔 |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 398c89361c0819f8761f5ca252f6d6ed2f353b47
|
|
@sbueringer: new pull request created: #9357 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Fixes the image repo.
Apparently new images are published to the new registry
Broke via #9349 (https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/periodic-cluster-api-e2e-main/1697533477378854912)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #