Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Define details of "Communicate key dates to the community" #9590

Merged
merged 1 commit into from
Oct 31, 2023
Merged

📖 Define details of "Communicate key dates to the community" #9590

merged 1 commit into from
Oct 31, 2023

Conversation

furkatgofurov7
Copy link
Member

@furkatgofurov7 furkatgofurov7 commented Oct 20, 2023 •
edited
Loading

What this PR does / why we need it:
Tries to better define Information/communication channels/stakeholders and remove TBDs'. Any suggestions to better define the above points are welcome

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of: #9104
Fixes: #9638

/area release
/kind documentation

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 20, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 20, 2023
@furkatgofurov7 furkatgofurov7 mentioned this pull request Oct 20, 2023
Closed
35 tasks
@furkatgofurov7
Copy link
Member Author

@kubernetes-sigs/cluster-api-release-team
/cc @killianmuldoon @sbueringer @CecileRobertMichon

CecileRobertMichon
CecileRobertMichon reviewed Oct 20, 2023
View reviewed changes
docs/release/release-tasks.md Outdated Show resolved Hide resolved
docs/release/release-tasks.md Outdated Show resolved Hide resolved
@furkatgofurov7 furkatgofurov7 mentioned this pull request Oct 20, 2023
Merged
@furkatgofurov7 furkatgofurov7 force-pushed the definde-key-dates-better branch from 370dd6b to e6afe69 Compare October 20, 2023 19:21
@furkatgofurov7
Copy link
Member Author

@CecileRobertMichon thanks for reviewing, updated it accordingly, PTAL.

@furkatgofurov7 furkatgofurov7 force-pushed the definde-key-dates-better branch from e6afe69 to 60fb27e Compare October 20, 2023 19:22
killianmuldoon
killianmuldoon reviewed Oct 23, 2023
View reviewed changes
docs/release/release-tasks.md Outdated Show resolved Hide resolved
docs/release/release-tasks.md Outdated Show resolved Hide resolved
docs/release/release-tasks.md Outdated Show resolved Hide resolved
docs/release/release-tasks.md Outdated Show resolved Hide resolved
docs/release/release-tasks.md Show resolved Hide resolved
@furkatgofurov7 furkatgofurov7 force-pushed the definde-key-dates-better branch from 60fb27e to b63b22a Compare October 23, 2023 11:19
@furkatgofurov7
Define details of "Communicate key dates to the community" in release…
69fa1b0 
… tasks doc

Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7 furkatgofurov7 force-pushed the definde-key-dates-better branch from b63b22a to 69fa1b0 Compare October 23, 2023 11:21
killianmuldoon
killianmuldoon reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8da39c70e9f589a611a45c9bf55eb9a9d00aabdf

@g-gaston
Copy link
Contributor

/lgtm

@furkatgofurov7
Copy link
Member Author

@CecileRobertMichon hey, sorry for the ping. If there are no outstanding comments to be addressed on this one, can we go ahead with this change?

@sbueringer
Copy link
Member

/approve

Looks good to me. Let's open a follow-up PR if there are further findings.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2427c0c into kubernetes-sigs:main Oct 31, 2023
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Oct 31, 2023
@furkatgofurov7 furkatgofurov7 deleted the definde-key-dates-better branch October 31, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@cahillsf cahillsf Awaiting requested review from cahillsf

@vincepri vincepri Awaiting requested review from vincepri

@sbueringer sbueringer Awaiting requested review from sbueringer

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@g-gaston g-gaston

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

Define details of "Communicate key dates to the community"
6 participants
@furkatgofurov7 @k8s-ci-robot @g-gaston @sbueringer @CecileRobertMichon @killianmuldoon