-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Propagate context on Manager.Start(...) #1205
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change reshuffles how the manager accepts and operates on a context. With this change, the user experience is greatly improved, users can now use `ctrl.SetupSignalHandler()` to create a context, enrich it if they want to, and pass it to `manager.Start`. In addition, this PR changes how the context and stop channel are handled internally to ensure proper cancellation. Signed-off-by: Vince Prignano <vincepri@vmware.com>
765a947
to
0f46012
Compare
@vincepri: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Would like to point out that this PR may have a secondary positive effect on test suites which utilize the controller test framework. By propagating the manager's cancelable |
@EronWright Thanks for pointing that out! I actually noticed the same on some flaky test within the Cluster API project, the other PR that merged a few days ago #1354 also helps if you need to wait for the cache to sync during tests. |
This change reshuffles how the manager accepts and operates on
a context. With this change, the user experience is greatly improved,
users can now use
ctrl.SetupSignalHandler()
to create a context, enrichit if they want to, and pass it to
manager.Start
.In addition, this PR changes how the context and stop channel are
handled internally to ensure proper cancellation.
/assign @alvaroaleman
/milestone v0.7.x