-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Don't hotloop on channel source closure #1362
🐛 Don't hotloop on channel source closure #1362
Conversation
Previously, when we received from the channel in a channel source, we didn't check if it was still open. This lead to hotlooping and spamming the source's handler/queue when the input channel is closed. Now, we stop the source when the channel is closed, similarly to what happens if the context is closed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Previously, when we received from the channel in a channel source, we
didn't check if it was still open. This lead to hotlooping and spamming
the source's handler/queue when the input channel is closed.
Now, we stop the source when the channel is closed, similarly to what
happens if the context is closed.