🐛 Correctly pass cache options on #1743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two bugs in this:
BuilderWithOptions
defaulted the opts it got from themanager with the ones it explicitly got, resulting in new fields
like
DefaultSelector
needing to explicitly be added thereDefaultSelector
wasn't correctly used everywhere, becausethere was code left that directly accessed the gvk -> selector map and
thus didn't get the default selector. Use a getter func rather than
the map internally, to make this impossible
/assign @vincepri