-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Panic in APIServer.Stop
when Authn == nil
#1785
Conversation
Welcome @jglick! |
Hi @jglick. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test Can we add a test case as well? |
Probably above my skill level. |
It looks to me like a side-effect of a more concerning bug. Why is it even nil? The documentation says there should be a default value if it's empty This line configures it if it is empty
@DirectXMan12 I think you wrote this, can you help us clarify? |
This is just a side effect of some other (properly reported) error: there is code which tries to clean up by stopping a service which in this case had not been fully initialized. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
I think this remains valid. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @hoegaarden |
@jglick you should make the test pass in order for us to merge it. maybe try to rebase? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AlmogBaku, jglick The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Rebased as suggestion. https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_controller-runtime/1785/pull-controller-runtime-test-master/1485692352398888960 is opaque to me. |
/lgtm |
There isn't much of a point in merging a fix without a test, the next change might just break it again. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If somebody else lands on this page when running controller when following this guide https://book.kubebuilder.io/reference/envtest.html. For me the issue was because |
After a test using this repo which failed with an error like
I saw a further error
This seems to be similar to #1724 (merged toward 0.11.0). Maybe related to #1750?
Untested (not known how to reproduce the original error with
etcd
).