Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Fix comment on LeaderElectionResourceLock #1903

Merged
merged 1 commit into from
May 25, 2022
Merged

📖 Fix comment on LeaderElectionResourceLock #1903

merged 1 commit into from
May 25, 2022

Conversation

FillZpp
Copy link
Contributor

@FillZpp FillZpp commented May 17, 2022

Signed-off-by: FillZpp FillZpp.pub@gmail.com

Fix comment on LeaderElectionResourceLock

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 17, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 17, 2022
@FillZpp
Copy link
Contributor Author

FillZpp commented May 20, 2022

@camilamacedo86 Hey, would you please take a look again?

camilamacedo86
camilamacedo86 approved these changes May 22, 2022
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shows for me 🥇
Just a nit.
If possible would be nice if we also describe the bad side effects in case someone does not follows the guidance. Otherwise, it is:

/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2022
This was referenced May 22, 2022
Merged
Closed
@FillZpp
Fix comment on LeaderElectionResourceLock
e4e13b9 
Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2022
@FillZpp
Copy link
Contributor Author

FillZpp commented May 24, 2022

@camilamacedo86 Could you approve this again?

camilamacedo86
camilamacedo86 approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2022
@camilamacedo86
Copy link
Member

@FillZpp I have permissions to lgtm only. We will need a second reviewer here to add the approved label.

@FillZpp
Copy link
Contributor Author

FillZpp commented May 25, 2022

@FillZpp I have permissions to lgtm only. We will need a second reviewer here to add the approved label.

Okey. @alvaroaleman Could you please take a look?

alvaroaleman
alvaroaleman approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, camilamacedo86, FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2022
@alvaroaleman
Copy link
Member

/retest

@camilamacedo86
Copy link
Member

/test pull-controller-runtime-test-master

@k8s-ci-robot k8s-ci-robot merged commit 196828e into kubernetes-sigs:master May 25, 2022
@k8s-ci-robot k8s-ci-robot added this to the v0.10.x milestone May 25, 2022
@camilamacedo86 camilamacedo86 mentioned this pull request Jun 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@alenkacz alenkacz Awaiting requested review from alenkacz

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees

@alvaroaleman alvaroaleman

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.10.x
Development

Successfully merging this pull request may close these issues.
4 participants
@FillZpp @camilamacedo86 @k8s-ci-robot @alvaroaleman