Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump k8s.io deps to v0.26.0 #2087

Merged
merged 1 commit into from
Dec 9, 2022
Merged

🌱 Bump k8s.io deps to v0.26.0 #2087

merged 1 commit into from
Dec 9, 2022

Conversation

lucacome
Copy link
Contributor

@lucacome lucacome commented Dec 9, 2022 •
edited
Loading

Signed-off-by: Luca Comellini luca.com@gmail.com

Updates k8s.io dependencies to stable v0.26.0

Closes #2035

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 9, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @lucacome!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @lucacome. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 9, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 9, 2022
@vincepri
Copy link
Member

vincepri commented Dec 9, 2022

/ok-to-test
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 9, 2022
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 9, 2022
@vincepri
Copy link
Member

vincepri commented Dec 9, 2022

@lucacome seems some linter issues to fix

@camilamacedo86
Copy link
Member

/test pull-controller-runtime-test-master

@lucacome
Bump k8s.io deps to v0.26.0
c774453 
Signed-off-by: Luca Comellini <luca.com@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2022
@lucacome
Copy link
Contributor Author

lucacome commented Dec 9, 2022

@vincepri I've fixed them

vincepri
vincepri approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucacome, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vincepri
Copy link
Member

vincepri commented Dec 9, 2022

/test pull-controller-runtime-test-master

@k8s-ci-robot k8s-ci-robot merged commit fb5e346 into kubernetes-sigs:master Dec 9, 2022
@czeslavo czeslavo mentioned this pull request Dec 9, 2022
Closed
@lucacome lucacome deleted the bump-k8s-deps branch December 9, 2022 20:48
@karelyatin karelyatin mentioned this pull request Dec 12, 2022
Closed
@Madhu-1 Madhu-1 mentioned this pull request Dec 13, 2022
Closed
arkodg added a commit to arkodg/gateway that referenced this pull request Dec 16, 2022
@arkodg
bump controller runtime to v0.14.0
caba70b 
Addresses kubernetes-sigs/controller-runtime#2035
which was fixed with kubernetes-sigs/controller-runtime#2087
and included in v0.14.0

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@everettraven everettraven mentioned this pull request Jan 23, 2023
Closed
13 tasks
@renovate renovate bot mentioned this pull request Feb 7, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@droot droot Awaiting requested review from droot

@FillZpp FillZpp Awaiting requested review from FillZpp

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump k8s to 1.26
4 participants
@lucacome @k8s-ci-robot @vincepri @camilamacedo86